Test logging #964
Merged
Test logging #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
approved these changes
May 29, 2021
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Remowrked test logging ala new test sauce * Lint * Update tests/middleware/test_logging.py Co-authored-by: Marcelo Trylesinski <[email protected]> * Update tests/middleware/test_logging.py Co-authored-by: Marcelo Trylesinski <[email protected]> * Update tests/middleware/test_logging.py Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #887 which gone stale, which was an alternative to #885
While #859 bug went unnoticed this test would have revealed it, nowhere we seem to test what the output of our default logging should be, this is a small addition to do it, it leverages @florimondmanca idea implementation in #887