-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtimes/js: Added middleware functionality #1631
Open
fredr
wants to merge
7
commits into
main
Choose a base branch
from
fredr/ts-middleware-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All committers have signed the CLA. |
fredr
force-pushed
the
fredr/ts-middleware-improvements
branch
from
December 6, 2024 09:43
2924d37
to
04dd70c
Compare
fredr
commented
Dec 6, 2024
@@ -32,6 +55,7 @@ pub fn meta(req: &model::Request) -> Result<RequestMeta, serde_json::Error> { | |||
.map(serde_json::to_value) | |||
.transpose()?, | |||
headers: serialize_headers(&rpc.req_headers), | |||
middleware_data: req.middleware_data.lock()?.clone().map(PVals), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine, as there shouldn't be any contention on this lock, but alternatively we can add a function that fetches this data on demand instead
fredr
force-pushed
the
fredr/ts-middleware-improvements
branch
from
December 12, 2024 08:55
04dd70c
to
a2c3481
Compare
fredr
force-pushed
the
fredr/ts-middleware-improvements
branch
from
December 18, 2024 12:56
a2c3481
to
7c5d4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to set custom status codes and an api for passing data from middlewares to the handler.
To access data in the handler