forked from opensearch-project/data-prepper
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Snappy as a compression option in the S3 sink: adds new option and en…
…gine, adds missing unit test for the CompressionOption class, make other compression engine classes package private. (opensearch-project#3155) Signed-off-by: David Venable <[email protected]>
- Loading branch information
Showing
6 changed files
with
140 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
.../java/org/opensearch/dataprepper/plugins/sink/s3/compression/SnappyCompressionEngine.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package org.opensearch.dataprepper.plugins.sink.s3.compression; | ||
|
||
import org.xerial.snappy.SnappyOutputStream; | ||
|
||
import java.io.IOException; | ||
import java.io.OutputStream; | ||
|
||
class SnappyCompressionEngine implements CompressionEngine { | ||
@Override | ||
public OutputStream createOutputStream(final OutputStream outputStream) throws IOException { | ||
return new SnappyOutputStream(outputStream); | ||
} | ||
} |
51 changes: 51 additions & 0 deletions
51
...st/java/org/opensearch/dataprepper/plugins/sink/s3/compression/CompressionOptionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package org.opensearch.dataprepper.plugins.sink.s3.compression; | ||
|
||
import org.junit.jupiter.api.extension.ExtensionContext; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.Arguments; | ||
import org.junit.jupiter.params.provider.ArgumentsProvider; | ||
import org.junit.jupiter.params.provider.ArgumentsSource; | ||
import org.junit.jupiter.params.provider.EnumSource; | ||
|
||
import java.util.stream.Stream; | ||
|
||
import static org.hamcrest.CoreMatchers.equalTo; | ||
import static org.hamcrest.CoreMatchers.instanceOf; | ||
import static org.hamcrest.MatcherAssert.assertThat; | ||
import static org.junit.jupiter.params.provider.Arguments.arguments; | ||
|
||
class CompressionOptionTest { | ||
@ParameterizedTest | ||
@EnumSource(CompressionOption.class) | ||
void fromOptionValue_returns_expected_value(final CompressionOption option) { | ||
assertThat(CompressionOption.fromOptionValue(option.getOption()), equalTo(option)); | ||
} | ||
|
||
@ParameterizedTest | ||
@EnumSource(CompressionOption.class) | ||
void getCompressionEngine_returns_a_CompressionEngine(final CompressionOption option) { | ||
assertThat(option.getCompressionEngine(), instanceOf(CompressionEngine.class)); | ||
} | ||
|
||
@ParameterizedTest | ||
@ArgumentsSource(OptionToExpectedEngine.class) | ||
void getCompressionEngine_returns_expected_engine_type(final CompressionOption option, final Class<CompressionEngine> expectedEngineType) { | ||
assertThat(option.getCompressionEngine(), instanceOf(expectedEngineType)); | ||
} | ||
|
||
static class OptionToExpectedEngine implements ArgumentsProvider { | ||
@Override | ||
public Stream<? extends Arguments> provideArguments(final ExtensionContext context) { | ||
return Stream.of( | ||
arguments(CompressionOption.NONE, NoneCompressionEngine.class), | ||
arguments(CompressionOption.GZIP, GZipCompressionEngine.class), | ||
arguments(CompressionOption.SNAPPY, SnappyCompressionEngine.class) | ||
); | ||
} | ||
} | ||
} |
61 changes: 61 additions & 0 deletions
61
...a/org/opensearch/dataprepper/plugins/sink/s3/compression/SnappyCompressionEngineTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
package org.opensearch.dataprepper.plugins.sink.s3.compression; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.xerial.snappy.SnappyCodec; | ||
import org.xerial.snappy.SnappyInputStream; | ||
import org.xerial.snappy.SnappyOutputStream; | ||
|
||
import java.io.ByteArrayInputStream; | ||
import java.io.ByteArrayOutputStream; | ||
import java.io.IOException; | ||
import java.io.OutputStream; | ||
import java.nio.charset.StandardCharsets; | ||
import java.util.UUID; | ||
|
||
import static org.hamcrest.CoreMatchers.equalTo; | ||
import static org.hamcrest.CoreMatchers.instanceOf; | ||
import static org.hamcrest.MatcherAssert.assertThat; | ||
import static org.junit.jupiter.api.Assertions.assertTrue; | ||
import static org.mockito.Mockito.mock; | ||
|
||
class SnappyCompressionEngineTest { | ||
|
||
private SnappyCompressionEngine createObjectUnderTest() { | ||
return new SnappyCompressionEngine(); | ||
} | ||
|
||
@Test | ||
void createOutputStream_should_return_SnappyOutputStream() throws IOException { | ||
final OutputStream innerOutputStream = mock(OutputStream.class); | ||
final OutputStream outputStream = createObjectUnderTest().createOutputStream(innerOutputStream); | ||
|
||
assertThat(outputStream, instanceOf(SnappyOutputStream.class)); | ||
} | ||
|
||
@Test | ||
void createOutputStream_should_write_compressed_data() throws IOException { | ||
final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); | ||
|
||
final OutputStream outputStream = createObjectUnderTest().createOutputStream(byteArrayOutputStream); | ||
|
||
final byte[] inputBytes = UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8); | ||
|
||
outputStream.write(inputBytes); | ||
outputStream.close(); | ||
|
||
final byte[] writtenBytes = byteArrayOutputStream.toByteArray(); | ||
|
||
assertTrue(SnappyCodec.hasMagicHeaderPrefix(writtenBytes)); | ||
|
||
final ByteArrayInputStream verificationInputStream = new ByteArrayInputStream(writtenBytes); | ||
|
||
final SnappyInputStream uncompressingInputStream = new SnappyInputStream(verificationInputStream); | ||
final byte[] uncompressedBytes = uncompressingInputStream.readAllBytes(); | ||
assertThat(uncompressedBytes, equalTo(inputBytes)); | ||
} | ||
} |