flecks (tm) #52
Merged
flecks (tm) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art (deciding who to send packets too).
# Conflicts: # src/main/java/dev/enjarai/trickster/EndecTomfoolery.java
… line flecks work but are ugly
need upstream changes to build
StellarWitch7
requested changes
Sep 22, 2024
src/main/resources/assets/trickster/lavender/entries/tome_of_tomfoolery/ploys/flecks.md
Outdated
Show resolved
Hide resolved
src/main/java/dev/enjarai/trickster/spell/trick/fleck/AbstactFleckTrick.java
Outdated
Show resolved
Hide resolved
src/main/resources/assets/trickster/lavender/entries/tome_of_tomfoolery/ploys/flecks.md
Outdated
Show resolved
Hide resolved
|
Just woke up, give me a bit to review it as well before merge please! ^^ |
|
I think @Vlue wanted you to take a look at the UVs. |
|
Oh also just noticed that the abstract fleck trick has been misspelled. In addition, I see that the excess |
enjarai
approved these changes
Sep 22, 2024
I dont have any issue with the UVs as is. Sure, they're a bit squished near the end of the line, but that isn't an issue imo. |
StellarWitch7
approved these changes
Sep 23, 2024
|
Some conflicts need to be resolved locally, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rai made me do it