This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Handle/cache offline-capable mode media requests in service worker #465
Commits on Nov 14, 2022
-
-
-
Fix: always serve current state of offline worker script
This only affects dev, but otherwise requires a server restart to make any service worker changes
-
- Claim clients immediately on activation. It's not clear this completely eliminates the need for a reload, but it does get part of the way there. - Don't attempt to cache responses for non-GET requests
-
Fix: remove stale versioned caches
Also, no reason for an array of keys which only ever has a length of one
-
-
-
Fix: always use the same cache key when requesting the page itself
This should not vary between different forms. This actually fixes a bug in both the current implementation as well as the previous changes on this branch: 1. Request offline-capable Form A while online 2. Request offline-capable Form B while online 3. Any changes which would trigger a service worker update 4. Request offline-capable Form A again while online, which updates the service worker and wipes out the previous cache 5. Request offline-capable Form B while OFFLINE, which will fail because its cached HTML has been removed Unless or until there is some meaningful difference in the HTML served for different forms, this change should be safe because the HTML and service worker will both be re-cached at the same time
-
-
-
-
Document updated offline/caching behavior
# Conflicts: # tutorials/37-offline.md # Conflicts: # tutorials/37-offline.md
-
Remove blocking on initial form cache update
And unnecessary try/catch block around initial non-blocking servicer worker update check
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.