This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
feat(geo): added geocoder api backend for mapbox and google #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes enketo/enketo#1158
I have verified this PR works with
What else has been done to verify that this works as intended?
Test configuration providers using
Why is this the best possible solution? Were any other approaches considered?
This moves the geocoding service to the backend api so that different geocode providers can be used. It is ideal since it moves the auth tokens away from the client and offers additional protection for the secrets, as well as the additonal functionality of using different geocode providers.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should continue working as expected for existing users. The google auth token is now protected from the client application and the /api/geo/geocoder is used instead.
Do we need any specific form for testing your changes? If so, please attach one.
No - just a map widget