This repository has been archived by the owner on Oct 1, 2022. It is now read-only.
[DO NOT MERGE] Testing with different engine and skipping or adding todos to failing… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnR
commented
Jun 11, 2019
|
|
||
| } ); | ||
| // TODO do we need this? | ||
| // import { g } from '../docwin'; |
test/spec/axis-native.spec.js
Outdated
| } ); | ||
| } ); | ||
| // TODO I think I missed this initially. Need to revisit all tests. | ||
| // import helpers from '../helpers'; |
There was a problem hiding this comment.
Ok, though they are not currently used, I think axes are a major area for expansion of our spec, especially preceding-sibling I believe browser support them thankfully.
| @@ -14,16 +14,18 @@ describe( 'creating expressions', () => { | |||
| const test = () => { | |||
| g.doc.createExpression( 'aa&&aa', resolver ); | |||
| }; | |||
|
|
|||
| expect( test ).to.throw( g.win.XPathException.INVALID_EXPRESSION_ERR ); //,/DOM XPath Exception 51/); | |||
| // TODO Is this good enough? | |||
|
|
||
| expect( test ).to.throw( g.win.XPathException.NAMESPACE_ERR ); | ||
| // TODO Is this good enough? | ||
| expect( test ).to.throw(); |
| @@ -34,7 +34,9 @@ describe( 'XPath expression evaluation', () => { | |||
| result = g.doc.evaluate( "namespace::node()", g.doc.getElementById( 'testContextNodeParameterNamespace' ), null, g.win.XPathResult.ANY_UNORDERED_NODE_TYPE, null ); | |||
| item = result.singleNodeValue; | |||
| expect( item ).to.not.equal( null ); | |||
| expect( item.nodeType ).to.equal( 13 ); | |||
| //TODO chrome/firefox do not support namespace:node() but we get | |||
| // same result with '.' - Is this node type important? | |||
There was a problem hiding this comment.
No, not important, I think. Can be commented out.
| @@ -27,7 +27,7 @@ describe( 'nodeset id() function', () => { | |||
| helpers.checkNodeResult( "id('FunctionNodesetIdCaseSimpleDoesNotExist')", g.doc, [] ); | |||
| } ); | |||
|
|
|||
| it( 'returns empty result if the default namespace for the node is empty', () => { | |||
| xit( 'returns empty result if the default namespace for the node is empty', () => { | |||
There was a problem hiding this comment.
I don't think these 4 commented-out tests are important.
| @@ -3,7 +3,7 @@ import { g } from '../docwin'; | |||
| describe( 'number operators', () => { | |||
|
|
|||
|
|
|||
| it( '+ works', () => { | |||
| xit( '+ works', () => { | |||
There was a problem hiding this comment.
Important, all of the xit tests in this file
| @@ -13,14 +13,16 @@ describe( 'location path', () => { | |||
| result = g.doc.evaluate( "namespace::node()", node, null, g.win.XPathResult.ANY_UNORDERED_NODE_TYPE, null ); | |||
| item = result.singleNodeValue; | |||
| expect( item ).to.not.equal( null ); | |||
| expect( item.nodeType ).to.equal( 13 ); | |||
| // TODO chrome/firefox do not support namespace::node but | |||
There was a problem hiding this comment.
No, I don't think this is important
| @@ -70,13 +70,15 @@ describe( 'Union operator', () => { | |||
| ] ); | |||
| } ); | |||
|
|
|||
| it( 'combines different attributes on the same element', () => { | |||
| //TODO Is node order important? chrome vs firefox return different order. | |||
| xit( 'combines different attributes on the same element', () => { | |||
| helpers.checkNodeResult( "id('eee40')/attribute::*[2] | id('eee40')/attribute::*[1]", g.doc, [ | |||
There was a problem hiding this comment.
That's fine. We can keep this commented out.
| @@ -95,7 +97,8 @@ describe( 'Union operator', () => { | |||
| ); | |||
| } ); | |||
|
|
|||
| it( 'combines a namespace and attribute', () => { | |||
| //TODO Is node order important? chrome vs firefox return different order. | |||
| xit( 'combines a namespace and attribute', () => { | |||
There was a problem hiding this comment.
No, not important, I think.
|
@vimemo, I made comments inline. Please let me know if I forgot anything or if you'd like to discuss further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tests
Not an actual pull request, but using as a tool to comment inline on the code.
Tests run about 6x faster with the new engine which is a nice improvement :)
I didn't comment on the tests you are already marked with TODO.