Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove safety from the optional lint dependencies as it's not used in this project. #49

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Remove safety from the optional lint dependencies as it's not used in this project. #49

merged 5 commits into from
Oct 21, 2024

Conversation

cipherself
Copy link
Contributor

@cipherself cipherself commented Oct 18, 2024 •
edited
Loading

No description provided.

@cipherself cipherself changed the title Remove safety from the optional lint dependencies as it's not used … Remove safety from the optional lint dependencies as it's not used in this project. Oct 18, 2024
@cipherself cipherself self-assigned this Oct 18, 2024
@cipherself cipherself force-pushed the minor/remove-safety-from-dependencies branch from 9399749 to 374bb3f Compare October 21, 2024 09:01
@cipherself
Remove html_theme_path as get_html_theme_path() has been deprecat…
035d712 
…ed and the warning highlights that it's safe to remove that code in that case.
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Coverage results

Update on 2024-10-21 09:41:41.297568441 +0000

This is the coverage report for commit f2c31eb

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        70      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      52      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           44      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                8      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py                           7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 117      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                                  25      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 529      0   100%

4 empty files skipped.

@cipherself cipherself marked this pull request as ready for review October 21, 2024 09:25
@cipherself cipherself requested review from a team, daniel-k and denizs and removed request for a team October 21, 2024 09:25
daniel-k
daniel-k requested changes Oct 21, 2024
View reviewed changes
src/enlyze/schema.py Outdated Show resolved Hide resolved
@cipherself @daniel-k
Update src/enlyze/schema.py
f2c31eb 
Co-authored-by: Daniel Krebs <[email protected]>
@cipherself cipherself requested a review from daniel-k October 21, 2024 09:56
@cipherself cipherself merged commit 077c3d3 into master Oct 21, 2024
9 checks passed
@cipherself cipherself deleted the minor/remove-safety-from-dependencies branch October 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-k daniel-k daniel-k approved these changes

@denizs denizs Awaiting requested review from denizs denizs was automatically assigned from enlyze/cloud

Assignees

@cipherself cipherself

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipherself @daniel-k