Overhaul for stable #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a large module to sort through, but the hope is that it avoids the need to constantly hop around without rhyme or reason to find the piece of logic you're looking for. The module structure is mapped to functionality rather than an arbitrary concept of reducing line number.
Remove unused imports Disable redundant errors Add notes for why errors are disabled
I went back and fourth on this, but ultimately decided that it's more trouble than it's worth. Between false positives, deeply nested packages raising vulnerabilities, and the brittleness of the poetry-plugin-export that the tooling relies on, it causes more headaches than it avoids. A future PR will enable dependabot tooling that will open PRs to automatically fix this problem so I don't have to deal with it anymore (hopefully)
See here for indept explanation: psf/black#4175 See here (and related) for the attitude: asottile/reorder-python-imports#366
Fix typing errors
Standardize on "import module" format rather than "from module import foo" format Remove _poetry stub module since we directly depend on the poetry package now Fix conflicts between modules and parameters both named 'poetry' Fixes #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of the final push towards a stable release of this project. It's also an update to get the project back into a healthy state after a long hiatus.
Summary of changes:
[poetry]extra with explicit dependencies on Poetry while still accounting for Poetry potentially not being installed (Fixes Request: Recommend users to explicitly depend on poetry instead of[poetry]extra #79)FileNotFoundErrorthat happens whenpoetry.lockdoes not exist (Fixes ERROR: Error creating virtualenv. Note that spaces in paths are not supported by virtualenv. Error details: FileNotFoundError(2, 'No such file or directory') #81)tox_poetry_installer.hookssubmodule #93)Work for the next PR: