Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safe tx hash replacement #892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: safe tx hash replacement #892

wants to merge 1 commit into from

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Oct 3, 2024

previously when using safe, the safe transaction hash was not being updated to the normal transaction hash once it was found. this lead to a race condition in the etherscan transaction finder logic since the transaction hash at the expected nonce of the transaction was mismatched, so the transaction would be updated to show as failed.

changes:

  • update safe transaction hash => transaction hash through a repriced onReplaced callback

@TateB TateB requested a review from sugh01 as a code owner October 3, 2024 22:59
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant