Add allowed package sources policy #1212
+168
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,6 +188,101 @@ test_external_references_disallowed_no_purl if { | |
| }]} | ||
| } | ||
|
|
||
| test_allowed_package_sources if { | ||
| expected := {{ | ||
| "code": "sbom_cyclonedx.allowed_package_sources", | ||
| "term": "pkg:generic/[email protected]?download_url=https://openssl.org/source/openssl-1.1.0g.tar.gz", | ||
| # regal ignore:line-length | ||
| "msg": `Package pkg:generic/[email protected]?download_url=https://openssl.org/source/openssl-1.1.0g.tar.gz fetched by cachi2 was sourced from "https://openssl.org/source/openssl-1.1.0g.tar.gz" which is not allowed`, | ||
| }} | ||
|
|
||
| att := json.patch(_sbom_attestation, [ | ||
| { | ||
| "op": "add", | ||
| "path": "/statement/predicate/components/-", | ||
| "value": { | ||
| "type": "file", | ||
| "name": "openssl", | ||
| "purl": "pkg:generic/[email protected]?download_url=https://openssl.org/source/openssl-1.1.0g.tar.gz", | ||
| "properties": [{ | ||
| "name": "cachi2:found_by", | ||
| "value": "cachi2", | ||
| }], | ||
| "externalReferences": [{"type": "distribution", "url": "https://openssl.org/source/openssl-1.1.0g.tar.gz"}], | ||
| }, | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/statement/predicate/components/-", | ||
| "value": { | ||
| "type": "library", | ||
| "name": "batik-anim", | ||
| "purl": "pkg:maven/org.apache.xmlgraphics/[email protected]?type=pom", | ||
| "properties": [{ | ||
| "name": "cachi2:found_by", | ||
| "value": "cachi2", | ||
| }], | ||
| # regal ignore:line-length | ||
| "externalReferences": [{"type": "distribution", "url": "https://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-anim/1.9.1/batik-anim-1.9.1.pom"}], | ||
| }, | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/statement/predicate/components/-", | ||
| "value": { | ||
| "type": "file", | ||
| "name": "unrelated", | ||
| "purl": "pkg:generic/unrelated", | ||
| "externalReferences": [{"type": "distribution", "url": "https://irrelevant.org"}], | ||
| }, | ||
| }, | ||
| ]) | ||
|
|
||
| lib.assert_equal_results(expected, sbom_cyclonedx.deny) with input.attestations as [att] | ||
| with data.rule_data as {sbom.rule_data_allowed_package_sources_key: [ | ||
| { | ||
| "type": "maven", | ||
| "patterns": [".*apache.org.*", ".*example.com.*"], | ||
| }, | ||
| { | ||
| "type": "generic", | ||
| "patterns": [".*apache.org.*", ".*example.com.*"], | ||
| }, | ||
| ]} | ||
| } | ||
|
|
||
| test_allowed_package_sources_no_rule_defined if { | ||
| expected := {{ | ||
| "code": "sbom_cyclonedx.allowed_package_sources", | ||
| "term": "pkg:maven/org.apache.xmlgraphics/[email protected]?type=pom", | ||
| # regal ignore:line-length | ||
| "msg": `Package pkg:maven/org.apache.xmlgraphics/[email protected]?type=pom fetched by cachi2 was sourced from "https://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-anim/1.9.1/batik-anim-1.9.1.pom" which is not allowed`, | ||
| }} | ||
|
|
||
| att := json.patch(_sbom_attestation, [{ | ||
| "op": "add", | ||
| "path": "/statement/predicate/components/-", | ||
| "value": { | ||
| "type": "library", | ||
| "name": "batik-anim", | ||
| "purl": "pkg:maven/org.apache.xmlgraphics/[email protected]?type=pom", | ||
| "properties": [{ | ||
| "name": "cachi2:found_by", | ||
| "value": "cachi2", | ||
| }], | ||
| # regal ignore:line-length | ||
| "externalReferences": [{"type": "distribution", "url": "https://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-anim/1.9.1/batik-anim-1.9.1.pom"}], | ||
| }, | ||
| }]) | ||
|
|
||
| # rule data is defined only for purl of type generic | ||
| lib.assert_equal_results(expected, sbom_cyclonedx.deny) with input.attestations as [att] | ||
| with data.rule_data as {sbom.rule_data_allowed_package_sources_key: [{ | ||
| "type": "generic", | ||
| "patterns": [".*example.com.*"], | ||
| }]} | ||
| } | ||
|
|
||
| test_attributes_not_allowed_no_properties if { | ||
| att := json.patch(_sbom_attestation, [{ | ||
| "op": "remove", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the
rule_data_errorsrules above. Let's add a new one that verifies the consistency of this new rule data key. This helps us determine if the rule data provided has any problems.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding out on this until the the comment about rule data format is settled.