Revert "Resolve TA image reference at runtime" #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f229b13. This was breaking ci in the build-definitions repo. There, the `latest` release of this is pulled and used, which means that whenever a new trusted artifacts bundle is available, suddenly CI fails for *all* changes until those bundle references are updated and merged. We should rely on renovate to bump those references, like other bundle references so we can manage it in a controlled fashion.
Renovate didn't do a good job at it in konflux-ci/build-definitions#1137, I was thinking this wasn't the best idea, and decided to go for it as we do not update build-trusted-artifacts that often. |
|
The downside of reverting this is that the image will always revert to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f229b13.
This was breaking ci in the build-definitions repo.
There, the
latestrelease of this is pulled and used, which means that whenever a new trusted artifacts bundle is available, suddenly CI fails for all changes until those bundle references are updated and merged.We should rely on renovate to bump those references, like other bundle references so we can manage it in a controlled fashion.