Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tash: Configure formatter to put spaces after > #93

Closed

Conversation

simonbaird
Copy link
Member

Not sure why anyone would want to remove that space.

(Expecting a CI failure here.)

@simonbaird simonbaird marked this pull request as draft June 12, 2024 19:25
@simonbaird
Copy link
Member Author

simonbaird commented Jun 12, 2024

I made the test pass with this in tash/golden/sast-snyk-check/ta.yaml but that seems weird and wrong..

-        snyk code test $ARGS $SOURCE_CODE_DIR --sarif-file-output=sast_snyk_check_out.json 1>&2>> stdout.txt || SNYK_EXIT_CODE=$?
+        snyk code test $ARGS $SOURCE_CODE_DIR --sarif-file-output=sast_snyk_check_out.json 1>&2>> stdout.txt  || SNYK_EXIT_CODE=$?

Why a space after the filename..?

@simonbaird
Copy link
Member Author

I don't mind abandoning this, just wanted to try it out..

Not sure why anyone would want to remove that space.
@@ -91,7 +91,7 @@ spec:

SNYK_EXIT_CODE=0
SOURCE_CODE_DIR=/var/workdir/source
snyk code test $ARGS $SOURCE_CODE_DIR --sarif-file-output=sast_snyk_check_out.json 1>&2>> stdout.txt || SNYK_EXIT_CODE=$?
snyk code test $ARGS $SOURCE_CODE_DIR --sarif-file-output=sast_snyk_check_out.json 1>&2>> stdout.txt || SNYK_EXIT_CODE=$?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space here seems wrong.

@simonbaird simonbaird closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant