Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

111 - Install from pip requirements and disable python 3.8 #112

Merged
merged 3 commits into from
Nov 20, 2024
Merged

111 - Install from pip requirements and disable python 3.8 #112

merged 3 commits into from
Nov 20, 2024

Conversation

EdwinWiseOne
Copy link
Contributor

@EdwinWiseOne EdwinWiseOne commented Nov 19, 2024 •
edited
Loading

Closes #106
Closes #107
Closes #111

  • Remove all support for Python 3.8
  • Update GitHub workflows to EDM 4.0
  • Add support to install pip dependencies from a requirements.txt file
  • Change the app_config.yaml format to have both edm and pip app_deps

This needs to be published at the same time as the corresponding changes in the edge CLI

Testing

Built and ran every example using the local CI

@EdwinWiseOne EdwinWiseOne requested a review from dpinte November 19, 2024 15:46
dpinte
dpinte requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment to address

Streamlit/requirements.txt Show resolved Hide resolved
@EdwinWiseOne EdwinWiseOne requested a review from dpinte November 20, 2024 14:47
@EdwinWiseOne EdwinWiseOne merged commit 3ce8641 into main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EdwinWiseOne @dpinte