Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PySide as a test dependency #1791

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions .github/workflows/run-traits-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ on:
- pull_request
- workflow_dispatch

env:
# Temporary workaround prior to release of TraitsUI 8.0
# xref: enthought/traits#1742
ETS_QT4_IMPORTS: 1

jobs:
tests:
strategy:
Expand All @@ -20,19 +15,6 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Install Linux packages for Qt support
run: |
sudo apt-get update
sudo apt-get install libegl1
sudo apt-get install libxkbcommon-x11-0
sudo apt-get install libxcb-cursor0
sudo apt-get install libxcb-icccm4
sudo apt-get install libxcb-image0
sudo apt-get install libxcb-keysyms1
sudo apt-get install libxcb-randr0
sudo apt-get install libxcb-render-util0
sudo apt-get install libxcb-shape0
if: matrix.os == 'ubuntu-latest'
Comment on lines -23 to -35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tidy up! One less place to remember all the X11 packages...

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
Expand All @@ -44,9 +26,6 @@ jobs:
- name: Create clean test directory
run: |
mkdir testdir
- name: Test Traits package (Linux)
run: cd testdir && xvfb-run -a python -m unittest discover -v traits
if: matrix.os == 'ubuntu-latest'
- name: Test Traits package (Windows/macOS)
run: cd testdir && python -m unittest discover -v traits
if: matrix.os != 'ubuntu-latest'
- name: Test Traits package
run: python -m unittest discover -v traits
working-directory: testdir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, TIL working-directory context in GH Actions.

Quite handy indeed.

1 change: 0 additions & 1 deletion etstool.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"lark-parser",
"mypy",
"numpy",
"pyside6",
"Sphinx",
"sphinx_copybutton",
"traitsui",
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ def get_long_description():
"mypy",
"numpy",
"pyface",
"PySide6",
"setuptools",
"Sphinx>=2.1.0",
"traitsui",
Expand Down
Loading