Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundId changes #84

Merged
merged 2 commits into from
Jan 5, 2025
Merged

RoundId changes #84

merged 2 commits into from
Jan 5, 2025

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Jan 5, 2025

  • added conversion from u8 to RoundId and comparison of RoundId with u8.
  • renamed Round::entry_round() to entry_round_id() and made it mandatory to implement. This helps avoid bugs when making combinators (like the one fixed in chain)

@coveralls
Copy link

coveralls commented Jan 5, 2025

Pull Request Test Coverage Report for Build 12621866283

Details

  • 8 of 13 (61.54%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 69.981%

Changes Missing Coverage Covered Lines Changed/Added Lines %
manul/src/combinators/chain.rs 2 4 50.0%
manul/src/combinators/misbehave.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
manul/src/combinators/chain.rs 1 56.49%
Totals Coverage Status
Change from base Build 12621719975: -0.05%
Covered Lines: 1830
Relevant Lines: 2615

💛 - Coveralls

@fjarri fjarri merged commit e00f790 into entropyxyz:master Jan 5, 2025
8 checks passed
@fjarri fjarri deleted the round-id branch January 5, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants