Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtocolMessagePart::assert_is_none()
- it was the opposite of what it should have really saidSessionReport::brief()
- do not show parts of the report that have no entriesrun_sync()
Some details on the latter. When writing tests for invalid echo messages, I noticed that the test sometimes fails without generating an evidence, but rather complaining that an unexpected message was encountered. The full sequence of events was the following:
Session
for that node sees there's an echo message and assumes there's an echo roundIt could be fixed by making the user explicitly declare if there's an echo round, regardless of there being an echo broadcast, but that means more boilerplate in every round declaration. Instead I chose to make the message delivery in
run_sync()
ordered (for each node separately), so that the main round message arrives first and triggers the expected error.The unordered delivery is still valuable for
manul
self-testing, so it is left as an option (although currently not used).