This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Prepare for v0.2.0 npm publish #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benschac
reviewed
Nov 15, 2023
| @@ -4,7 +4,7 @@ | |||
| "John Sahhar <[email protected]>" | |||
| ], | |||
| "description": "x25519 & chacha20poly1305", | |||
| "version": "0.1.0", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
dumb question: would this be a patch?
There was a problem hiding this comment.
Yeah i wasn't sure, i think its sort of grey area. In some cases encrypt_and_sign will give different output than before, because it used to give a uint8array containing the word 'failed' on failure, now it throws an error.
|
small nit: merge if it's not relevent. LGTM. outside of scope: would be cool if we added something like changesets https://github.com/changesets/changesets would be cool. |
benschac
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just bumps the minor version and rebuilds for nodejs