Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump wasmvm to v1.2.6 #160

Merged
merged 3 commits into from
Jan 11, 2024
Merged

bump wasmvm to v1.2.6 #160

merged 3 commits into from
Jan 11, 2024

Conversation

hoank101
Copy link

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hoank101 hoank101 mentioned this pull request Jan 11, 2024
19 tasks
@anilcse
Copy link
Collaborator

anilcse commented Jan 11, 2024

Yes, I was going to update as per https://twitter.com/simon_warta/status/1745089431134970024?t=DwyNS_REyS_tQfH2dPLP4A&s=19. Thanks for the updated pr

@anilcse
Copy link
Collaborator

anilcse commented Jan 11, 2024

Can you please resolve the conflicts

@hoank101
Copy link
Author

Can you please resolve the conflicts

resolved

@codecov-commenter
Copy link

Codecov Report

Merging #160 (78d3b93) into releases/v2.x (2856a28) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           releases/v2.x     #160   +/-   ##
==============================================
  Coverage          54.74%   54.74%           
==============================================
  Files                 25       25           
  Lines               2285     2285           
==============================================
  Hits                1251     1251           
  Misses               959      959           
  Partials              75       75           

@anilcse anilcse merged commit 0c3181c into envadiv:releases/v2.x Jan 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants