Skip to content

Commit

Permalink
quic: Use MaybeSendRstStreamFrame instead of ResetWriteSide in a quic…
Browse files Browse the repository at this point in the history
… test (#37182)

quic: Use MaybeSendRstStreamFrame instead of ResetWriteSide in a quic
test

ResetWriteSide is deprecated and will be removed once this usage of it
is removed.
Risk Level: None - test only
Testing: existing unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Ryan Hamilton <[email protected]>
  • Loading branch information
RyanTheOptimist authored Nov 18, 2024
1 parent a9bfac3 commit 9a2dc62
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/integration/quic_http_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2512,7 +2512,9 @@ TEST_P(QuicHttpIntegrationTest, StreamTimeoutWithHalfClose) {
static_cast<EnvoyQuicClientSession*>(codec_client_->connection());
quic::QuicStream* stream = quic_session->GetActiveStream(0);
// Only send RESET_STREAM to close write side of this stream.
stream->ResetWriteSide(quic::QuicResetStreamError::FromInternal(quic::QUIC_STREAM_NO_ERROR));
quic_session->MaybeSendRstStreamFrame(
stream->id(), quic::QuicResetStreamError::FromInternal(quic::QUIC_STREAM_NO_ERROR),
stream->stream_bytes_written());

// Wait for the server to timeout this request and the local reply.
EXPECT_TRUE(response->waitForEndStream());
Expand Down

0 comments on commit 9a2dc62

Please sign in to comment.