api: add ConnectionPoolSettings into ProxyProtocolUpstreamTransport #37177
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Context: envoyproxy#37126 ConnectionPoolSettings in proxy_protocol upstream socket customizes the behavior of connection pool. Signed-off-by: Yuchen Dai <[email protected]>
|
/retest |
| // Control the connection pool settings for PROXY protocol socket. | ||
| // [#not-implemented-hide:] | ||
| ConnectionPoolSettings connection_pool_settings = 3; | ||
| } | ||
|
|
||
| // ConnectionPool settings for PROXY protocol socket. | ||
| message ConnectionPoolSettings { |
There was a problem hiding this comment.
I don't think "connection pool" is the right term here? These are socket settings? Or just ProxyProtocolSettings? Can these settings just be inlined?
/wait
There was a problem hiding this comment.
These are impacting envoy conn pool setting for proxy_procotol transport socket.
I put here because the ConnectionPoolSettings is in the uptream_proxy_protocol package.
Do you mean inline in ProxyProtocolUpstreamTransport?
Sure
There was a problem hiding this comment.
I think I would just inline the settings. The the user the fact that they impact connection pool sharing is an implementation details. I would just document as appropriate what each setting does.
There was a problem hiding this comment.
Thank you! Does the new proto align with your opinion?
Signed-off-by: Yuchen Dai <[email protected]>
Signed-off-by: Yuchen Dai <[email protected]>
Commit Message:
Add
ConnectionPoolSettingsin proxy_protocol upstream transport socket.It customizes the behavior of connection pool.
Additional Description:
Risk Level: LOW
Testing: CI
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #37126
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]