Provide callback to decide if nack should be retried #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaysngupta
force-pushed
the
aksgupta/nacks
branch
from
ce8096b to
6a5c248
Compare
akshaysngupta
changed the title
akshaysngupta
force-pushed
the
aksgupta/nacks
branch
3 times, most recently
from
6a806b2 to
4f6b703
Compare
Signed-off-by: Akshay Gupta <[email protected]>
akshaysngupta
force-pushed
the
aksgupta/nacks
branch
from
4f6b703 to
74d3af5
Compare
|
I'm not sure about this in principle. If a response is rejected by the client, then isn't the right approach to actually remove the invalid configuration from the cache? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when go-control-plane receives a NACK from Envoy, it proceeds by resending the same request again. This causes Envoy to send the NACK causing a never-ending loop.
Some have suggested to that rate limiting Envoy can help but this is not required when it is apparent that error will not go away.
To give implementors ability to select when they want to retry sending the response, This PR adds
OnStreamResponseNackedandOnStreamDeltaResponseNackedcallbacks which are called when Envoy responds with aNACKfor a previous response sent by go-control-plane.Fixes #46