Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/sync: Remove NO_BUILD_SETUP to ensure llvm is setup #812

Merged
merged 1 commit into from
Oct 31, 2023
Merged

ci/sync: Remove NO_BUILD_SETUP to ensure llvm is setup #812

merged 1 commit into from
Oct 31, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 31, 2023 •
edited
Loading

Fix #811

@phlax
Copy link
Member Author

phlax commented Oct 31, 2023

this still doesnt work - i have raised a PR to test this in ci (#813 ) and one to try and address the underlying issue wrt calling envoy's ci externally (without use of the build container) envoyproxy/envoy#30634

@phlax
Copy link
Member Author

phlax commented Oct 31, 2023

ive tested this and reasonably confident things should be working now, so ill land it to unbreak sync

@phlax phlax merged commit 06e3d2c into envoyproxy:main Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpeach jpeach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync is now broken
2 participants
@phlax @jpeach