Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move go mod tidy to run in sync_protos #911

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Mar 26, 2024

Was being run in build_protos and also not git adding any changed go.mod/go.sum files

Also re-runs go mod tidy locally to fix up main

Not run after API sync, should be in future runs of the sync

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia requested a review from mmorel-35 March 26, 2024 14:11
@sunjayBhatia sunjayBhatia requested a review from mmorel-35 March 26, 2024 14:48
@sunjayBhatia sunjayBhatia changed the title Rerun go mod tidy on main module Move go mod tidy to run in sync_protos Mar 26, 2024
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sunjayBhatia

@sunjayBhatia sunjayBhatia merged commit 363e6e2 into envoyproxy:main Mar 26, 2024
5 checks passed
@sunjayBhatia sunjayBhatia deleted the fix-go-mod-tidy branch March 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants