Make the fix_format and check_format scripts work on Nighthawk code

[dubious90]

Fixes #913

Direct changes:

• Modified config.yaml to not exclude the current directory, which was excluding all of NH
• Overrode some settings in config.yaml to move past some code changes
  • Filed Stop using deprecated mock method macros #914 and Investigate moving off of direct google::protobuf types #915 to address these overrides in the future
• Moved include_dir_order from check_format.sh over to the config.yaml where it now needs to live.

Also ran the format script to fix all current code formatting errors.

Signed-off-by: Nathan Perry [email protected]

[dubious90]

@qqustc Please review and assign to @mum4k when done.

[mum4k]

I am trying to verify if this list contains all the directories it should, but I am having a hard time figuring out how these map into the list of our actual directories here:

https://github.com/envoyproxy/nighthawk

This seems to be a list of top level and sub-level directories. Can you help me understand what this list should contain and how it is used?

E.g. the following directories are missing here, is that intentional?

• benchmarks (no c++ code, so probably ok)
• adaptive_load

[dubious90]

The short answer is I'm not 100% sure what this list's intention is. I copied this directly from:
--include_dir_order envoy,nighthawk,external/source/envoy,external,api,common,source,exe,server,client,distributor,sink,grpcpp,request_source,test_common,test

which did not contain adaptive_load or benchmarks.

My understanding of this list is that we probably have more things here than we actually need. Anything omitted I believe gets bundled into one section and alphabetized within that section. This list is ordered, so will ensure that (for example) external/source/envoy appears before anything else in external. I assume that for some envoy-related thing that header order matters, but for most files/subdirectories it shouldn't, and it would probably be fine to have them bundled in one section.

I don't remember what it is, but we've typically added directories to this list upon some mysterious error that we have encountered on occasion, but I forget what it is, or if it is still relevant after this yaml migration.

[mum4k]

Thank you, feel free to merge in assuming the files in the adaptive_load directories do get formatted even though they aren't listed.

[dubious90]

We talked about this offline, but after running an experiment, I realized that we are in fact missing some features in those directories. I am going to follow up separately adding directories and fixing issues

[mum4k]

Thank you, feel free to merge in assuming the files in the adaptive_load directories do get formatted even though they aren't listed.