Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dual Sending (Standalone) #1185

Closed
wants to merge 1 commit into from
Closed

feat: Dual Sending (Standalone) #1185

wants to merge 1 commit into from

Conversation

alexrisch
Copy link
Collaborator

Bumps SDK to support dual sending

Bumps SDK to support dual sending
@alexrisch alexrisch requested a review from a team as a code owner November 12, 2024 19:36
@alexrisch alexrisch changed the base branch from main to release/2.0.8 November 12, 2024 19:36
@@ -379,7 +383,7 @@ export const loadConversations = async (
const knownGroups: GroupWithCodecsType[] = [];
const updatedGroups: GroupWithCodecsType[] = [];

groups.forEach((g) => {
groups.forEach(async (g) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using forEach with async callbacks won't wait for the promises to complete, which could lead to race conditions. Consider using a for...of loop instead:

for (const g of groups) {
  // existing code
}

This ensures each group is processed sequentially and all promises are properly awaited.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@alexrisch alexrisch changed the base branch from release/2.0.8 to main November 12, 2024 19:38
@alexrisch alexrisch marked this pull request as draft November 12, 2024 19:38
@alexrisch alexrisch changed the title feat: Dual Sending feat: Dual Sending (Standalone) Nov 12, 2024
Copy link
Contributor

Performance Comparison Report

  • Current: 9ece2c6 - 2024-11-12 19:40:20Z
  • Baseline: main (4a68dd4) - 2024-11-12 19:39:24Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 1.3 ms → 1.3 ms 1 → 1
Avatar Image 50 runs render 1.1 ms → 1.1 ms (-0.0 ms, -1.9%) 1 → 1
Empty Avatar 10 runs render 1.0 ms → 0.9 ms (-0.1 ms, -10.0%) 1 → 1
Empty Avatar 50 runs render 0.7 ms → 0.7 ms (-0.1 ms, -8.1%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 1 2 1 2 1 2 1 1 1 1
Warmup runs: 3

Current
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 2 1 1 1 1 2 2 1 1 1
Warmup runs: 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 1.1 ms
Stdev: 0.3 ms (25.4%)
Runs: 1 1 1 1 1 1 1 2 1 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 2 1 2 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Warmup runs: 1

Current
Mean: 1.1 ms
Stdev: 0.2 ms (22.6%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 1 1 1 1 1 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 1.0 ms
Stdev: 0.0 ms (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Warmup runs: 72

Current
Mean: 0.9 ms
Stdev: 0.3 ms (35.1%)
Runs: 1 1 1 1 0 1 1 1 1 1
Warmup runs: 8
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.7 ms
Stdev: 0.4 ms (59.9%)
Runs: 1 1 0 1 1 1 1 1 1 1 0 1 1 1 0 1 0 1 1 0 1 1 1 1 1 1 1 1 1 1 0 1 0 1 0 1 1 1 1 1 0 1 0 1 0 1 0 1 0 1
Warmup runs: 1

Current
Mean: 0.7 ms
Stdev: 0.5 ms (69.3%)
Runs: 0 0 0 1 1 1 1 0 1 0 0 1 1 0 1 0 0 1 1 1 1 1 1 0 1 0 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 1 0 1 1 0 0 0 1
Warmup runs: 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against a32393a

@alexrisch alexrisch closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant