Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling Single Fetch #876

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Enabling Single Fetch #876

wants to merge 12 commits into from
+116 −134

Conversation

hakimLyon
Copy link
Contributor

This PR enables the v3_singleFetch feature.

@kentcdodds
Copy link
Member

Thank you! Could you debug the playwright failures please?

@hakimLyon hakimLyon closed this Oct 16, 2024
@hakimLyon hakimLyon reopened this Oct 16, 2024
kentcdodds
kentcdodds requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have a few notes.

app/routes/_auth+/auth.$provider.ts Outdated Show resolved Hide resolved
app/root.tsx Outdated Show resolved Hide resolved
app/routes/users+/index.tsx Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
davidesigner
davidesigner reviewed Oct 20, 2024
View reviewed changes
vite.config.ts Outdated Show resolved Hide resolved
@itsmegood
Copy link
Contributor

Will it be possible to have a codemod for this upgrade. Manually upgrading all this for custom/ extended project seems a bit difficult.

@kentcdodds
Copy link
Member

Maybe @jacobparis's tool could help.

@itsmegood
Copy link
Contributor

itsmegood commented Nov 14, 2024 •
edited
Loading

Maybe @jacobparis's tool could help.

I found this https://codemod.com/registry/remix-single-fetch-recipe by jacobparis.
Also curious about your thoughts on switching to biome? (less code/ faster)

@jacobparis
Copy link
Contributor

Maybe @jacobparis's tool could help.

I found this https://codemod.com/registry/remix-single-fetch-recipe by jacobparis. Also curious about your thoughts on switching to biome? (less code/ faster)

I should take that down, it's for an old outdated single fetch API

Remix team is working on some codemods for this now though

@itsmegood
Copy link
Contributor

Any update regarding this @kentcdodds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito left review comments

@davidesigner davidesigner davidesigner left review comments

@kentcdodds kentcdodds Awaiting requested review from kentcdodds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hakimLyon @kentcdodds @itsmegood @jacobparis @davidesigner @kettanaito