Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if first element of a NonParametric generation interval PMF is non-zero #806

Closed
sbfnk opened this issue Sep 30, 2024 · 2 comments · Fixed by #808
Closed

Error if first element of a NonParametric generation interval PMF is non-zero #806

sbfnk opened this issue Sep 30, 2024 · 2 comments · Fixed by #808

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Sep 30, 2024

          If `NonParametric` generation interval PMFs are going to be zero-indexed, I suggest erroring whenever there is non-zero mass in the 0 bin. I think this will cause the fewest (and the least costly) surprises for users.

Originally posted by @dylanhmorris in #799 (comment)

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 30, 2024

But if users might want this they could just set the first element to zero?

If what you mean is to go through a deprecation cycle for this I agree.

@seabbs
Copy link
Contributor

seabbs commented Sep 30, 2024

I changed my mind but yes agree on a depreciation cycle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants