Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 806: warn about nonparametric generation times #808

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Oct 1, 2024

Description

This PR closes #806. It produces a warning if the first element of a nonparametric PMF for the generation time is >0 and adds documentation.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@seabbs seabbs enabled auto-merge October 1, 2024 09:27
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 1e6f90c Oct 1, 2024
9 checks passed
@seabbs seabbs deleted the fix-check branch October 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if first element of a NonParametric generation interval PMF is non-zero
2 participants