Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle messaging around model treatment of missingness #774

Merged
merged 39 commits into from
Oct 16, 2024
Merged

Handle messaging around model treatment of missingness #774

merged 39 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. Add message about NA treatment for option "missing"

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7fc61fd View commit details
    Browse the repository at this point in the history

  2. Add missing tests for obs_opts

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8639fda View commit details
    Browse the repository at this point in the history

  3. Add NEWS item

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    68e8e1e View commit details
    Browse the repository at this point in the history

  4. Improve messages 

    Co-authored-by: Sebastian Funk <[email protected]>
    @jamesmbaazam @sbfnk
    jamesmbaazam and sbfnk committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bcfa714 View commit details
    Browse the repository at this point in the history

  5. Check if na is explicitly specified by user 

    Co-authored-by: Sebastian Funk <[email protected]>
    @jamesmbaazam @sbfnk
    jamesmbaazam and sbfnk committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    49d22ee View commit details
    Browse the repository at this point in the history

  6. Change less regular to non-daily

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4ae8b97 View commit details
    Browse the repository at this point in the history

  7. Create function to test for complete data

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d814317 View commit details
    Browse the repository at this point in the history

  8. Add tests for test_data_complete

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4902e41 View commit details
    Browse the repository at this point in the history

  9. Document test_data_complete

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6b6d695 View commit details
    Browse the repository at this point in the history

  10. Add function to crosscheck na as missing setting with data

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    82f1751 View commit details
    Browse the repository at this point in the history

  11. Move message elsewhere and only check if na is specified for later use

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    552cf00 View commit details
    Browse the repository at this point in the history

  12. Add new global

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b5271b7 View commit details
    Browse the repository at this point in the history

  13. Apply na cross checking function in main functions

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9037633 View commit details
    Browse the repository at this point in the history

  14. Rename dirty data

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a26ef4f View commit details
    Browse the repository at this point in the history

  15. Add test for na cross checking function

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3b60cf3 View commit details
    Browse the repository at this point in the history

  16. Add more tests to obs_opts

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9f356ac View commit details
    Browse the repository at this point in the history

  17. Remove global variable

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    225dac6 View commit details
    Browse the repository at this point in the history

  18. Use alternative syntax to avoid linting issues

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6f9f4e9 View commit details
    Browse the repository at this point in the history

  19. copy before modifying data.table

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    eecf8a1 View commit details
    Browse the repository at this point in the history

  20. Fix test

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    165fbce View commit details
    Browse the repository at this point in the history

  21. Update NEWS.md

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9548900 View commit details
    Browse the repository at this point in the history

  22. Make message/warning verbose and test for message/warning

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    77f74af View commit details
    Browse the repository at this point in the history

  23. Simplify comment

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    84823dc View commit details
    Browse the repository at this point in the history

  24. Use vapply for type safety

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9544434 View commit details
    Browse the repository at this point in the history

  25. Add lifecycle badge

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5b1ce6e View commit details
    Browse the repository at this point in the history

  26. Add lifecycle badge

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    27069a5 View commit details
    Browse the repository at this point in the history

  27. Improve docs

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ceab729 View commit details
    Browse the repository at this point in the history

  28. Return unmodified obs_opts

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    94dccd7 View commit details
    Browse the repository at this point in the history

  29. Move removal of element of obs_opts() into checker function

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    aa85bf6 View commit details
    Browse the repository at this point in the history

  30. Use setequal instead of checking lengths

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f515a94 View commit details
    Browse the repository at this point in the history

  31. Remove new unnecessary new lines

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4a068fc View commit details
    Browse the repository at this point in the history

  32. Remove trailing white space

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6d9f2cf View commit details
    Browse the repository at this point in the history

  33. Add test to check for expected element introduced

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4a09c46 View commit details
    Browse the repository at this point in the history

  34. Add new argument to pass column names

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    71fd1eb View commit details
    Browse the repository at this point in the history

  35. Add error for column mismatch

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7a0d2c4 View commit details
    Browse the repository at this point in the history

  36. Refactor for readability

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c405293 View commit details
    Browse the repository at this point in the history

  37. Perform missingness check on the raw data

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    28c373f View commit details
    Browse the repository at this point in the history

  38. Remove test that no longer applies

    @jamesmbaazam
    jamesmbaazam committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b1b1efb View commit details
    Browse the repository at this point in the history

  39. Add reviewer and PR number 

    Co-authored-by: Sebastian Funk <[email protected]>
    @jamesmbaazam @sbfnk
    jamesmbaazam and sbfnk committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9c578e5 View commit details
    Browse the repository at this point in the history