Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Study of different architectures of the engine (EPI-19) #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

📝 Study of different architectures of the engine (EPI-19) #7

wants to merge 1 commit into from

Conversation

landryarki
Copy link
Collaborator

comparing ECS and OOP based game engine

@landryarki
📝 architecture study of the game engine
31b8ad1 
using ECS or OOP based game engine
@landryarki landryarki added the documentation Improvements or additions to documentation label Sep 23, 2024
@landryarki landryarki self-assigned this Sep 23, 2024
@linear Linear
Copy link

linear bot commented Sep 23, 2024

EPI-19 Benchmarking differents architectures of the engine

@landryarki landryarki changed the base branch from main to develop September 23, 2024 15:54
@Marius-P1 Marius-P1 changed the title 📝 study of different architectures of the engine 📝 Study of different architectures of the engine Sep 23, 2024
@Marius-P1 Marius-P1 changed the title 📝 Study of different architectures of the engine 📝 Study of different architectures of the engine (EPI-19) Sep 23, 2024
RenardFute
RenardFute requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@RenardFute RenardFute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you can add or update the final sentence to explain our final choice (here OOP) and why we made that choice.

6im0n
6im0n reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@6im0n 6im0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good benchmark ! Just add a litle conclusion to introduce the OOP, and the schematics of the architecture 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6im0n 6im0n 6im0n left review comments

@RenardFute RenardFute RenardFute requested changes

@AubaneNourry AubaneNourry Awaiting requested review from AubaneNourry

@Marius-P1 Marius-P1 Awaiting requested review from Marius-P1

Requested changes must be addressed to merge this pull request.

Assignees

@landryarki landryarki

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landryarki @RenardFute @6im0n