🏗️ Rendering engine architecture (EPI-70) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endering-engine-architecture
RenardFute
requested changes
Oct 6, 2024
There was a problem hiding this comment.
Seems fine to me except the "initialize" stuff be I will let you check that part.
I mainly blocking this pr due to #15 not passing for now, open to debate on this.
RenardFute
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several enhancements and additions to the graphics-related components of the project. The most important changes involve the addition of a comparison operator to
IObject, the introduction of a comprehensiveGraphicsclass, and the creation of an interface for graphics components.Enhancements to
IObject:src/common/IObject.hpp: Added a comparison operator to allow for object comparison.Introduction of
Graphicsclass:src/graphics/Graphics.hpp: Introduced a newGraphicsclass to handle all graphics-related operations, including initializing and managing the SDL window and renderer, rendering objects, and maintaining rendering order based on z-index.Creation of
IGraphicsComponentinterface:src/graphics/IGraphicsComponent.hpp: Added a newIGraphicsComponentinterface to define the structure and functionality for graphics-related components, ensuring they can be properly managed and rendered.waiting for:
error classes
SDL2 installation in CI/CD -> canceled: changed to SFML