Bahadzie/issue7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahadzie
force-pushed
the
bahadzie/issue7
branch
from
10288fa
to
591d06c
Compare
bahadzie
force-pushed
the
bahadzie/issue7
branch
from
a196dc6
to
a66abca
Compare
Bisaloo
reviewed
Apr 9, 2024
R/numberize.R
Outdated
| "hundred", "", "", "", "", "", "", "", "", | ||
| "hundred", "two hundred", "three hundred", "four hundred", | ||
| "five hundred", "six hundred", "seven hundred", "eight hundred", | ||
| "nine hundred", | ||
| "thousand", "million", "billion", "trillion" |
There was a problem hiding this comment.
I understand the rest of the changes but could you explain why this is now necessary?
There was a problem hiding this comment.
If you mean filling out the 20s and 100s below
"twenty one", "twenty two", "twenty three", "twenty four",
"twenty five", "twenty six", "twenty seven", "twenty eight", "twenty nine",
...
"two hundred", "three hundred", "four hundred",
"five hundred", "six hundred", "seven hundred", "eight hundred", "nine hundred",
A string I tested was failing to numberize properly and this was the solution.
Now I cannot remember what string it was.
What I've learnt from this is to document any failing string as a test next time to
- be able to explain why the code changed
- potentially prevent a bug in future as the code is refactored and new features are added.
In the meantime I will try a few strings and see if I can come up with an example to justify it.
There was a problem hiding this comment.
I tested with a bunch of values and could not reproduce. If you don't come up with anything either, I suggest we drop it for now, until we have a specific test case.
Bisaloo
approved these changes
Apr 17, 2024
bahadzie
added a commit
that referenced
this pull request
Oct 7, 2024
* Handles text containing leading or trailing whitespace. Fixes #7 * Undo unnecessary changes in English word mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Also updates README.Rmd and README.md locally to see if it will avoid triggering
render_readmeGithub Action.