Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_stations argument for detection #565

Merged
merged 18 commits into from
Feb 9, 2024
Merged

Conversation

calum-chamberlain
Copy link
Member

What does this PR do?

Currently all templates are run that have any matching channels with the waveform data provided. It is common for users to then remove detections made on fewer than n stations. This PR adds this option to the detection process to reduce the compute when templates that would not make useful detections are included in the template set.

PR Checklist

  • develop base branch selected?
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGES.md.
    - [ ] First time contributors have added your name to CONTRIBUTORS.md.

@calum-chamberlain
Copy link
Member Author

TODO: Needs a test for client_detect. I missed that in the initial commits.

@calum-chamberlain calum-chamberlain merged commit 15681c0 into develop Feb 9, 2024
19 of 20 checks passed
@calum-chamberlain calum-chamberlain deleted the min-stations branch February 9, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant