Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pick from P pick #572

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Add option to pick from P pick #572

merged 7 commits into from
Jun 28, 2024

Conversation

calum-chamberlain
Copy link
Member

What does this PR do?

Adds the option to start magnitude picking windows from the P pick rather than the S.

Why was it initiated? Any relevant Issues?

When an S-pick is not present, the S-time is calculated (badly), which can lead to amplitude picking windows missing the body waves. Starting from the P pick is probably a better way to pick magnitude amplitudes as the definition of magnitudes is maximum body wave amplitude (usually).

PR Checklist

  • develop base branch selected?
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.

@calum-chamberlain calum-chamberlain merged commit d7d8ad3 into develop Jun 28, 2024
18 of 20 checks passed
@calum-chamberlain calum-chamberlain deleted the amp-pick-from-p branch June 28, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant