Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move h3 to inside the institution block #1248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michelmany
Copy link
Contributor

@michelmany michelmany commented Aug 19, 2024

https://equalizedigital.zendesk.com/agent/tickets/6391

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • ⏩ Revert

Description

It moves the H3 from before the block to inside the block and remove the class=screen-reader-text to make it visible.
https://equalizedigital.zendesk.com/agent/filters/75514237

Related Tickets & Documents

  • Related Issue #
  • Closes #
  • Related Basecamp To-do URL:
  • Related Support Ticket URL:

Proof of Functionality

Accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with Accessibility Checker or WAVE and addressed Error and Warning issues?

For more info, check out the
Accessibility Checker Documentation.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have run local linting and tests.
  • I have checked that the base branch is correctly set.
  • I have updated the documentation or README.md accordingly.

[optional] Are there any post deployment tasks we need to perform?

Additional Notes

It's already in production.

Copy link
Member

@SteveJonesDev SteveJonesDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants