Auto-commit patched spec to ensure changes are shown accurately #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Feb 13, 2023
| @@ -32,6 +32,7 @@ jobs: | |||
| git checkout ${GITHUB_REF##*/} | |||
| make docker_run | |||
| echo -e "Make execution completed." | |||
| git add spec/oas3.patched/. | |||
There was a problem hiding this comment.
Do we want to do this or #57? (or this now, 57 later)
There was a problem hiding this comment.
I think we should do this now, and maybe 57 later. Doing this now makes it easer to open & review spec update PRs: easier to open because all you have to do is update the spec/oas3.fetched directory, easier to review because the spec/oas3.patched directory will always be up-to-date, so it's easier to notice if the spec update had unintended consequences on the patching process.
displague
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.