-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes in integration test GH action #72
Conversation
The integratoin tests fail with .. that's what this PR should fix. It worked in my fork (which is the only way to test GH actions). |
@@ -31,7 +31,7 @@ jobs: | |||
run: | |||
working-directory: .ansible/collections/ansible_collections/equinix/cloud | |||
steps: | |||
- name: checkout Ansible collection | |||
- repository: checkout Ansible collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be a valid parameter for a step, nor a valid repository value:
Based on the value, I would think you may have meant to replace name
with run_name
, but not clear that that would fix anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@displague thanks for pointing it out. I wanted to change the name
param or the checkout action. name
there is invalid param, it should be repository
.
Since the head branch for this PR is part of this repository and not from a fork, and since the workflow exists in the An example run of the updated workflow is here: https://github.com/equinix-labs/metal-python/actions/runs/7491105603/workflow |
67f3850
to
895e7e6
Compare
895e7e6
to
5af0c85
Compare
5af0c85
to
1174feb
Compare
Thank you, I wasn't aware it's possible to specify ref for the action. |
5b53339
to
d2b1732
Compare
d2b1732
to
78e292c
Compare
@ctreatma @displague I finally have a successful run of the integration tests PR at: It runs tests from Ansible collection main (not any release), on with Python SDK from a tested PR. This is ready for review. |
This PR fixes GH action for integration tests.
The workflow should clone the ansible collection repo and install it. Right now it fails on pip install requirements because it's cloning this repo instead.