Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove category enum from plan drives spec #98

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Jun 6, 2024

Closes #97

@ctreatma
Copy link
Contributor Author

ctreatma commented Jun 6, 2024

There's a weird CI failure in here, and I'm at a loss as to why it's happening.

On an ansible-collection-equinix PR to upgrade metal-python to 0.10.0, the only test failure is the enum validation issue that this PR addresses: https://github.com/equinix-labs/ansible-collection-equinix/actions/runs/9407693322/job/25914037577?pr=191

On this PR, which is based on 0.10.0 (so the only code change here compared to that version is the removal of one enum validator), a different test is failing consistently: https://github.com/equinix-labs/metal-python/actions/runs/9407997426/job/25914997489?pr=98#step:10:3843

I'm leaning towards writing off that test failure as some sort of flake, since it makes no sense that removing an enum from Metal plans would impact the ability to look up a VRF attached to a virtual circuit.

@ctreatma ctreatma merged commit f93892a into main Jun 7, 2024
2 of 3 checks passed
@ctreatma ctreatma deleted the patch-plan-spec branch June 7, 2024 15:41
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR is included in version 0.10.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans do not match spec
1 participant