Fix quoted "otel-cli exec ..." example in README.md #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example from README:
# otel-cli propagates context via envvars so you can chain it to create child spans
otel-cli exec --kind producer "otel-cli exec --kind consumer sleep 1"
doesn't work, because we're running into equinix-labs#356.
It worked until `/bin/sh -c` was removed in equinix-labs#202.
|
@tobert feel free to merge this, I don't have the permissions to :) |
|
Thanks for this PR! I just want to remind @tobert that this is still waiting to be merged. |
|
Heya, I need to fix up some permissions of my own. I'll try to merge this
to the repo but I can't release and haven't been able to for a while.
I'll set aside some time soon to move this tool to somewhere I can make
releases from.
…-Amy
On Tue, Nov 12, 2024 at 11:20 AM hertznsk ***@***.***> wrote:
Thanks for this PR! I just want to remind @tobert
<https://github.com/tobert> that this is still waiting to be merged.
—
Reply to this email directly, view it on GitHub
<#357 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWSHUUK7ZOXSRTNQQR62T2AITGLAVCNFSM6AAAAABMNDE7PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZQHE3TCNZXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example from README:
doesn't work, because we're running into #356.
It worked until
/bin/sh -cwas removed in #202.