Pull in scripts from vendor-nutanix/test-suite as a starting point #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the (incomplete?) terraform to put devices in hybrid mode to avoid racing the test-suite scripts running in userdata
ctreatma
force-pushed
the
missing-interfaces
branch
from
a293882
to
813ba7e
Compare
ctreatma
changed the title
This reverts commit 1fe170f.
ctreatma
commented
Apr 12, 2024
Comment on lines
+20
to
+23
| EXTERNAL_BASE_URL="https://artifacts.platformequinix.com/vendors/nutanix" | ||
| export FOUNDATION_DISK_URL="$${EXTERNAL_BASE_URL}/test-suite/foundation/Foundation_VM-5.1-disk-0.qcow2" | ||
| export METIS_DISK_URL="$${EXTERNAL_BASE_URL}/test-suite/metis/nutanix-metis-2.8.6-77193790-disk1.qcow2" | ||
| export XRAY_DISK_URL="$${EXTERNAL_BASE_URL}/test-suite/x-ray/xray-3.8.qcow2" |
There was a problem hiding this comment.
The l2gateway VM came up after I updated the local scripts to match the main branch of the vendor-nutanix repo instead of the ones from SEK-380-update-test-suite, but the disk image downloads failed because those files aren't available locally. I added these so that the disk images will be downloaded from the remote source even though the script files are local...and now the l2gateway isn't coming up again. I don't know if these scripts are flaky (and if so, what their failure rate is), or if they only work on certain machine configurations within a given plan, or what.
|
Abandoning this in favor of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to debug issues with standing up a Nutanix cluster using this module, I came to the conclusion (maybe incorrectly?) that the scripts we are pulling down from
https://artifacts.platformequinix.com/vendors/nutanixdon't exactly line up with either of:Based on URL structure I've decided that the vendor-nutanix version of the scripts is closer to the correct version. I initially pulled the scripts from the
mainbranch, but opted to instead copy the scripts from https://github.com/equinixmetal/vendor-nutanix/pull/69 since the curl'ed scripts appear to include at least some of the changes in that PR.The local copy of the scripts serves as a starting point that we can easily modify without having to first figure out what repo the real scripts live in.