Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lalr parser for main ert config #9735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 14, 2025

This is for performance reasons. May cause ambiguous config files to no longer be parsed, but it should not have any effect.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This is for performance reasons. May cause ambiguous config files
to no longer be parsed.
@eivindjahren eivindjahren force-pushed the use_lalr_parser_for_main_ert_config branch from b04a7b2 to d7800df Compare January 14, 2025 12:06
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #9735 will not alter performance

Comparing eivindjahren:use_lalr_parser_for_main_ert_config (d7800df) with main (60fc8f8)

Summary

✅ 24 untouched benchmarks

@eivindjahren eivindjahren added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Jan 14, 2025
@eivindjahren eivindjahren self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant