Improve frontend #1773
Open
Improve frontend #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
improve-frontend
branch
from
3ef8c03
to
a54ca1f
Compare
mrica-equinor
force-pushed
the
improve-frontend
branch
from
a54ca1f
to
0730538
Compare
5 tasks
Eddasol
reviewed
Oct 22, 2024
| @@ -38,7 +37,7 @@ const StyledCard = styled(Card)` | |||
| flex: 1 0 0; | |||
| padding: 8px 16px; | |||
| flex-direction: row; | |||
| background: ${tokens.colors.ui.background__light.hex}; | |||
| background: ${tokens.colors.ui.background__default.hex}; | |||
There was a problem hiding this comment.
When changing the background I would also change the background color of this button:
So it matches this:
Eddasol
reviewed
Oct 22, 2024
| @@ -18,6 +18,9 @@ const Centered = styled.div` | |||
| align-items: center; | |||
| justify-content: center; | |||
| ` | |||
| const StyledButton = styled(Button)` | |||
| padding-left: 10px; | |||
There was a problem hiding this comment.
Not a fan of this padding
Before this change:
After this change:
Works on the large button version but not as good on the small version
Eddasol
reviewed
Oct 22, 2024
| @@ -129,6 +130,7 @@ export const MissionMapView = ({ mission }: MissionProps) => { | |||
|
|
|||
| return ( | |||
| <MapCard style={{ boxShadow: tokens.elevation.raised }}> | |||
| <Typography variant="h3">{mission.map?.mapName}</Typography> | |||
There was a problem hiding this comment.
Not a fan of this
If it should be kept the string needs to be formatted (remove "_" and ".png") and it should be removed for default map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.