Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong order choice children #813

Open
nesadrian opened this issue Oct 3, 2024 · 1 comment
Open

Wrong order choice children #813

nesadrian opened this issue Oct 3, 2024 · 1 comment
Assignees
@nesadrian
Labels
bug Unexpected behavior or defects in the application front-end Frontend code, functionality, or client-side interactions

Comments

@nesadrian
Copy link
Contributor

nesadrian commented Oct 3, 2024 •
edited
Loading

Even though the backend order seems to be correct, the frontend messes up the order of choice children. Probably related to the d3 hierarchy algorithm. I think this was fixed with the patch-package script, so start checking that first.
@nesadrian nesadrian added bug Unexpected behavior or defects in the application front-end Frontend code, functionality, or client-side interactions labels Oct 3, 2024
@nesadrian nesadrian mentioned this issue Oct 7, 2024
Closed
@nesadrian nesadrian self-assigned this Oct 7, 2024
@nesadrian
Copy link
Contributor Author

It looks like this issue is more complex than what was first assumed. We should start by looking at init-order.js, order/index.js and layout.js in dagre to fix this issue. Use "yarn patch-package dagre" once the changes in the node module are done and the issue is resolved to apply the changes for each yarn install.

Remove comment in nodeValidityHelper.js once this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesadrian nesadrian

Labels
bug Unexpected behavior or defects in the application front-end Frontend code, functionality, or client-side interactions
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/813-wrong-order-choice-children equinor/flyt
1 participant
@nesadrian