Concurrency for 2.0. Based on ecl2df and no eclsum caching #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* realization.get_smry() has changed to always return a dummy index * cache_eclsum is pruned from fmu-ensemble.
The argument column_keys is no longer accepted by get_smry_meta(). All smry metadata available to a realization/ensemble is now always returned by this function. This function is no longer the recommended practice for a client script to obtain the relevant summary vector metadata, API users should use the attrs["meta"] property of the returned summary dataframes instead.
ensemble.get_smr() will no longer ensure that the dates returned are identical in all realization, realizations with shorter timespans will not be extrapolated as they were before. This also affects get_smry_stats(), for which realizations which failed prematurely earlier had zero rates, affecting statistical profiles. Now these realization with truncated time-series will only affect the statistical profiles in the time-range they have data for.
* Batch processing after init on ensembles * Functionality for turning off concurrency * Concurrent apply() * Parallelize add_from_runpathfile * Allow running find_files at init of realizations * Parallelize get_smry()
Open
|
@berland is this still active? Should we move it to TODO? |
|
No, this PR is not active, and it is not clear that this is implemented correctly, the speedup is limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attempt for concurrency, taking over from #106.
Based on #182 , where eclsum caching is irrelevant.