Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various metrics to SearchContext. #346

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Conversation

rwiker
Copy link
Contributor

@rwiker rwiker commented Oct 15, 2024

Issue

N/A

Short description

Adds various metrics aggregation to search contexts, specifically, "min", "max", "avg", "sum", "stats", "extended_stats",
"percentiles", "value_count" and "cardinality". These are accessed through the metrics member on class SearchContext. See examples in examples/metrics.ipynb.

Pre-review checklist

  • Read through all changes. No redundant print() statements, commented-out code, or other remnants from the development. 👀
  • Make sure tests pass after every commit. ✅
  • New/refactored code is following same conventions as the rest of the code base. 🧬
  • New/refactored code is tested. ⚙
  • Documentation has been updated 🧾

Pre-merge checklist

  • Commit history is consistent and clean. 👌

@rwiker rwiker requested a review from a team October 15, 2024 11:15
equinor-ruaj
equinor-ruaj previously approved these changes Oct 16, 2024
Copy link
Contributor

@equinor-ruaj equinor-ruaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@equinor-ruaj equinor-ruaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rwiker rwiker merged commit e935ad1 into main Oct 17, 2024
25 checks passed
@rwiker rwiker deleted the feature/numerical-aggregations branch October 17, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants