Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style and testing workflows #58

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Add style and testing workflows #58

merged 2 commits into from
Dec 27, 2023

Conversation

xjules
Copy link
Collaborator

@xjules xjules commented Dec 19, 2023

In order to test new workflows, they are called from python-app.yml. Once successful I'll remove python-app.yml and remove the workflow_call trigger.

@xjules xjules self-assigned this Dec 19, 2023

- name: Run ruff
run: |
ruff komodoenv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff the tests also?

@pinkwah pinkwah force-pushed the add_wfs branch 2 times, most recently from b98db86 to 4618f24 Compare December 22, 2023 12:52
Co-authored-by: Julius Parulek <[email protected]>
@pinkwah pinkwah force-pushed the add_wfs branch 2 times, most recently from c4d5375 to 5a7e0eb Compare December 22, 2023 12:55
Co-authored-by: Julius Parulek <[email protected]>
jobs:
tests:
name: "Python ${{ matrix.python-version }}"
runs-on: ubuntu-20.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu 20.04 is the last Ubuntu to have Python 3.8 available in /usr.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pinkwah pinkwah merged commit 3bf33c4 into main Dec 27, 2023
5 checks passed
@pinkwah pinkwah deleted the add_wfs branch December 27, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants