-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style and testing workflows #58
Conversation
.github/workflows/style.yml
Outdated
|
||
- name: Run ruff | ||
run: | | ||
ruff komodoenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruff the tests also?
b98db86
to
4618f24
Compare
Co-authored-by: Julius Parulek <[email protected]>
c4d5375
to
5a7e0eb
Compare
Co-authored-by: Julius Parulek <[email protected]>
jobs: | ||
tests: | ||
name: "Python ${{ matrix.python-version }}" | ||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu-latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 20.04 is the last Ubuntu to have Python 3.8 available in /usr
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In order to test new workflows, they are called from python-app.yml. Once successful I'll remove python-app.yml and remove the workflow_call trigger.