Resolve tracked release name before writing to current release #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsevj
force-pushed
the
fix_actual_name
branch
from
1e0bc07
to
473197e
Compare
andreas-el
reviewed
Sep 23, 2024
| rp = path.resolve() | ||
| tracked_release = path.resolve() | ||
| if not (tracked_release / "root").is_dir(): | ||
| tracked_release = Path(str(tracked_release) + rhel_version_suffix()).resolve() |
There was a problem hiding this comment.
Should perhaps test the outcome of this? We are sure this won't fail ?
- Raise warning or errors if release not found on disk
larsevj
force-pushed
the
fix_actual_name
branch
from
90b9542
to
c2f5f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ensure that the current release always points to a specific release, and is consistent with where the update function updates from.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist