Bug error with flash calc (#843)

* bug: error with flash calc Gudrun * temporary "fix" bug in stabiilty analysis --------- Co-authored-by: Sviatoslav Eroshkin <[email protected]>
equinor · Nov 10, 2023 · 14bf3f8 · 14bf3f8
1 parent 6828284
commit 14bf3f8
Show file tree

Hide file tree

Showing 2 changed files with 186 additions and 1 deletion.
diff --git a/src/main/java/neqsim/thermodynamicOperations/flashOps/TPmultiflash.java b/src/main/java/neqsim/thermodynamicOperations/flashOps/TPmultiflash.java
@@ -375,7 +375,7 @@ public void stabilityAnalysis() {
         iter++;
         err = 0;
 
-        if (iter <= 150 || !system.isImplementedCompositionDeriativesofFugacity()) {
+        if (iter <= 250 || !system.isImplementedCompositionDeriativesofFugacity()) {
           if (iter % 7 == 0) {
             double vec1 = 0.0;
 

diff --git a/src/test/java/neqsim/thermodynamicOperations/flashOps/GudrunDegasser.java b/src/test/java/neqsim/thermodynamicOperations/flashOps/GudrunDegasser.java
@@ -0,0 +1,185 @@
+package neqsim.thermodynamicOperations.flashOps;
+
+import java.util.ArrayList;
+import java.util.List;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import neqsim.thermo.phase.PhaseEosInterface;
+import neqsim.thermodynamicOperations.ThermodynamicOperations;
+
+/**
+ * @author ESOL
+ *
+ */
+class GudrunDegasser {
+  static neqsim.thermo.system.SystemInterface testSystem = null;
+  static ThermodynamicOperations testOps = null;
+
+  /**
+   * @throws java.lang.Exception
+   */
+  @BeforeEach
+  void setUp() throws Exception {
+    testSystem = new neqsim.thermo.system.SystemPrEos(243.15, 300.0);
+    testSystem.addComponent("methane", 90.0);
+    testSystem.addComponent("ethane", 0.0);
+    testSystem.addComponent("propane", 0.0);
+    testSystem.addComponent("i-butane", 0.0);
+    testSystem.addComponent("n-butane", 0.0);
+    testSystem.addComponent("i-pentane", 0.0);
+    testSystem.addComponent("n-pentane", 0.0);
+    testSystem.addComponent("n-hexane", 0.0);
+    testSystem.addComponent("nitrogen", 10.0);
+    testSystem.setMixingRule("classic");
+  }
+
+  /**
+   * Test method for {@link neqsim.thermodynamicOperations.flashOps.PHFlash#run()}.
+   */
+  @Test
+  void testRun() {
+    neqsim.thermo.system.SystemInterface fluid1 =
+        new neqsim.thermo.system.SystemSrkCPAstatoil(273.15 + 42.0, 10.00);
+
+    fluid1.addComponent("nitrogen", 0.110282450914383);
+    fluid1.addComponent("CO2", 8.92014980316162);
+    fluid1.addComponent("methane", 72.3870849609375);
+    fluid1.addComponent("ethane", 5.19349813461304);
+    fluid1.addComponent("propane", 5.20273065567017);
+    fluid1.addComponent("i-butane", 0.436239510774612);
+    fluid1.addComponent("n-butane", 1.39356422424316);
+    fluid1.addComponent("i-pentane", 0.769362509250641);
+    fluid1.addComponent("n-pentane", 0.543137490749359);
+    fluid1.addComponent("n-hexane", 3.90587639808655);
+    fluid1.addComponent("n-heptane", 3.90587639808655);
+    fluid1.addComponent("water", 40.0);
+    fluid1.setMixingRule(10);
+    fluid1.setMultiPhaseCheck(true);
+
+    ThermodynamicOperations testOps = new ThermodynamicOperations(fluid1);
+
+    testOps.TPflash();
+
+    double[] intParameter = {
+
+        -0.24, // "CO2"
+
+        -0.721, // "methane"
+
+        0.11, // "ethane"
+
+        0.205, // "propane"
+
+        0.081, // "i-butane"
+
+        0.17, // "n-butane"
+
+        0.051, // "i-pentane"
+
+        0.1135, // "n-pentane"
+
+        0.0832, // "n-hexane"
+
+        0.0535 // "n-heptane"
+
+    };
+
+
+    String[] componentNames = fluid1.getComponentNames();
+
+    for (int i = 0; i < intParameter.length; i++) {
+
+      int componentIndex = findComponentIndex(componentNames, componentNames[i + 1]);// except
+                                                                                     // nitrogen 0
+      int waterIndex = findComponentIndex(componentNames, "water");
+
+      if (componentIndex != -1 && waterIndex != -1) {
+
+        ((PhaseEosInterface) fluid1.getPhases()[0]).getMixingRule()
+            .setBinaryInteractionParameter(componentIndex, waterIndex, intParameter[i]);
+
+        ((PhaseEosInterface) fluid1.getPhases()[1]).getMixingRule()
+            .setBinaryInteractionParameter(componentIndex, waterIndex, intParameter[i]);
+
+      } else {
+      }
+    }
+
+    testOps.TPflash();
+    fluid1.prettyPrint();
+
+    List<Double> molarComposition = new ArrayList<>();
+    molarComposition.add(0.07649963805789309);
+    molarComposition.add(10.028287212684818);
+    molarComposition.add(49.52052228615394);
+    molarComposition.add(3.64093888905641);
+    molarComposition.add(3.6620992636511893);
+    molarComposition.add(0.2995511776378937);
+    molarComposition.add(0.9605423088257289);
+    molarComposition.add(0.5032398365065283);
+    molarComposition.add(0.36145746378993904);
+    molarComposition.add(0.2364703087561068);
+    molarComposition.add(2.732003176453634);
+    molarComposition.add(27.978388438425913);
+
+    double[] molarCompositionArray =
+        molarComposition.stream().mapToDouble(Double::doubleValue).toArray();
+
+    neqsim.thermo.system.SystemInterface fluid_test_separator = fluid1.clone();
+    fluid_test_separator.setMolarComposition(molarCompositionArray);
+
+    neqsim.processSimulation.processEquipment.stream.Stream inlet_stream_test_sep =
+        new neqsim.processSimulation.processEquipment.stream.Stream("TEST_SEPARATOR_INLET",
+            fluid_test_separator);
+    inlet_stream_test_sep.setTemperature(72.6675872802734, "C");
+    inlet_stream_test_sep.setPressure(10.6767892837524, "bara");
+    inlet_stream_test_sep.setFlowRate(721.3143271348611, "kg/hr");
+    inlet_stream_test_sep.run();
+
+
+    neqsim.processSimulation.processEquipment.separator.ThreePhaseSeparator test_separator =
+        new neqsim.processSimulation.processEquipment.separator.ThreePhaseSeparator(
+            inlet_stream_test_sep);
+    test_separator.setName("TEST_SEPARATOR");
+    test_separator.run();
+    test_separator.getWaterOutStream().getThermoSystem().prettyPrint();
+
+    neqsim.processSimulation.processEquipment.heatExchanger.Heater heater_TP_setter_test_stream =
+        new neqsim.processSimulation.processEquipment.heatExchanger.Heater(
+            "TP_SETTER_FOR_THE_DEGASSER_TEST_SEP_STREAM", test_separator.getWaterOutStream());
+    heater_TP_setter_test_stream.setOutPressure(5.9061164855957 - 0.01, "bara");
+    heater_TP_setter_test_stream.setOutTemperature(79.8487854003906, "C");
+    heater_TP_setter_test_stream.run();
+    System.out.println("Gas out from degasser " + heater_TP_setter_test_stream.getOutStream()
+        .getFluid().getPhase("gas").getFlowRate("kg/hr"));
+    heater_TP_setter_test_stream.getOutStream().getThermoSystem().prettyPrint();
+
+    neqsim.processSimulation.processEquipment.heatExchanger.Heater heater_TP_setter_test_stream2 =
+        new neqsim.processSimulation.processEquipment.heatExchanger.Heater(
+            "TP_SETTER_FOR_THE_DEGASSER_TEST_SEP_STREAM", test_separator.getWaterOutStream());
+    heater_TP_setter_test_stream2.setOutPressure(5.9061164855957, "bara");
+    heater_TP_setter_test_stream2.setOutTemperature(79.8487854003906, "C");
+    heater_TP_setter_test_stream2.run();
+
+    System.out.println("Gas out from degasser2 " + heater_TP_setter_test_stream2.getOutStream()
+        .getFluid().getPhase("gas").getFlowRate("kg/hr"));
+
+  }
+
+
+
+  private int findComponentIndex(String[] componentNames, String componentName) {
+
+    for (int i = 0; i < componentNames.length; i++) {
+
+      if (componentNames[i].equals(componentName)) {
+
+        return i;
+
+      }
+    }
+
+    return -1; // Component not found
+
+  }
+}