Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: replace PhaseType.byValue with PhaseType enum #1252

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 10, 2025 21:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 36 lines in your changes missing coverage. Please review.

Project coverage is 41.17%. Comparing base (58c04dd) to head (77dad58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...m/thermodynamicoperations/flashops/SolidFlash.java 0.00% 4 Missing ⚠️
.../thermodynamicoperations/flashops/SolidFlash1.java 0.00% 4 Missing ⚠️
...thermodynamicoperations/flashops/SolidFlash12.java 0.00% 4 Missing ⚠️
.../java/neqsim/thermo/mixingrule/EosMixingRules.java 0.00% 3 Missing ⚠️
...qsim/mathlib/nonlinearsolver/SysNewtonRhapson.java 0.00% 2 Missing ⚠️
...eqsim/thermo/component/ComponentHydratePVTsim.java 0.00% 2 Missing ⚠️
...n/java/neqsim/thermo/component/ComponentSolid.java 33.33% 2 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 77.77% 2 Missing ⚠️
...ertygenerator/OLGApropertyTableGeneratorWater.java 0.00% 2 Missing ⚠️
...rator/OLGApropertyTableGeneratorWaterStudents.java 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1252      +/-   ##
============================================
+ Coverage     41.14%   41.17%   +0.03%     
- Complexity     6019     6025       +6     
============================================
  Files           721      721              
  Lines         68274    68272       -2     
  Branches       8153     8153              
============================================
+ Hits          28093    28113      +20     
+ Misses        38503    38488      -15     
+ Partials       1678     1671       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update

@asmfstatoil asmfstatoil merged commit 2180e83 into equinor:master Jan 11, 2025
9 checks passed
@asmfstatoil asmfstatoil deleted the use_phasetype branch January 11, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants